Closed
Bug 1230774
Opened 9 years ago
Closed 9 years ago
reveal.js links do not work because hit-testing doesn't find them
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox43 | --- | unaffected |
firefox44 | --- | unaffected |
firefox45 | + | unaffected |
firefox46 | + | fixed |
firefox47 | --- | fixed |
People
(Reporter: azakai, Assigned: mattwoodrow)
References
()
Details
(Keywords: qawanted, regression, testcase-wanted)
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On
http://kripken.github.io/mloc_emscripten_talk/#/2
if you press right-arrow or space, you'll see some links, to BananaBread, Qt, and Ruby. In Chrome, those animate when hovered over, and when clicked, they open the link. In Firefox, they look like plain text, and do not function as links, nor does the animation show.
Reporter | ||
Updated•9 years ago
|
Comment 1•9 years ago
|
||
The basic issue is that that location on screen doesn't seem to hit-test to that element. See what happens if you try to select it with the element picker in the devtools inspector.
Now _why_ that is, I'm not sure yet. A smaller testcase would probably be pretty useful.
Keywords: qawanted,
testcase-wanted
Summary: reveal.js links do not work → reveal.js links do not work because hit-testing doesn't find them
Reporter | ||
Comment 2•9 years ago
|
||
I investigated if this was anything specific to my slides, but looks like no, the problem happens on the official reveal.js demo as well,
http://lab.hakim.se/reveal-js/#/3
So it likely affects all reveal.js-using projects.
I also checked a few versions of Firefox. This runs ok on 44/aurora, so it looks like it is only broken on nightly currently - a recent regression?
Keywords: regression
Comment 3•9 years ago
|
||
[Tracking Requested - why for this release]:
OK, this regressed (at least the "not animating" part; the clicking part broke sometime later) between the 2015-11-16 nightly and the 2014-11-17 nightly. That's the range in which bug 1208673 landed, which would be consistent with the transforms involved in this testcase and the other regressions from that bug...
Updated•9 years ago
|
status-firefox43:
--- → unaffected
status-firefox44:
--- → unaffected
status-firefox45:
--- → affected
Comment 5•9 years ago
|
||
Still happens on m-c tip, so not a dupe of bug 1226904.
status-firefox46:
--- → affected
tracking-firefox46:
--- → ?
Tracking for 45+ since this is a recent regression.
Comment 7•9 years ago
|
||
The change that caused this regression was backed out from Firefox 45. A current Developer Edition build should now work correctly, or you can wait until 45 goes to Beta some time next week.
https://hg.mozilla.org/releases/mozilla-aurora/rev/64ec448f156d
Reporter | ||
Comment 8•9 years ago
|
||
Are there plans to back this out of 46 and 47? The regression is still present on at least nightly/47.
Meanwhile I found another testcase that is hit by this (test_html5_mouse in the emscripten test suite), let me know if it would be useful to post it.
Comment 9•9 years ago
|
||
We're hoping to fix the regressions. Not only is backing out risky (because it landed many moons ago, and there are probably many implicit dependencies by now) but APZ/e10s depends on some of the behaviour from those patches, and backing out could delay APZ/e10s.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → matt.woodrow
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8712467 -
Flags: review?(roc)
Comment on attachment 8712467 [details] [diff] [review]
Use correct Z order to sort perspective items
Review of attachment 8712467 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Matt!
Attachment #8712467 -
Flags: review?(roc) → review+
Comment 12•9 years ago
|
||
Yes, thanks Matt! (I should just cc you on all the things, let you swoop in and fix them :p)
Comment 13•9 years ago
|
||
Comment 14•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment 15•9 years ago
|
||
bugherder |
Matt, want to request uplift to aurora? Thanks!
Flags: needinfo?(matt.woodrow)
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8712467 [details] [diff] [review]
Use correct Z order to sort perspective items
Approval Request Comment
[Feature/regressing bug #]: Bug 1168263
[User impact if declined]: Incorrect hit testing on some websites.
[Describe test coverage new/current, TreeHerder]: Manually tested, added test
[Risks and why]: Very low risk.
[String/UUID change made/needed]: None
Flags: needinfo?(matt.woodrow)
Attachment #8712467 -
Flags: approval-mozilla-aurora?
Comment on attachment 8712467 [details] [diff] [review]
Use correct Z order to sort perspective items
Fix for recent regression. We want links to work! Please uplift to aurora.
Attachment #8712467 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 19•9 years ago
|
||
bugherder uplift |
Comment 20•9 years ago
|
||
Seems this isn't entirely fixed.
STR:
1) load http://yonet.github.io/d3-codeclass/#/9 in Dev Edition or Nightly
2) Click "JSFiddle" in the slide
EXPECTED: page navigates to http://jsfiddle.net/yonet3d/cw6s96my/
ACTUAL: nothing.
The same problem reproduces on http://lab.hakim.se/reveal-js/#/3, when trying to click on http://slides.com
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 21•9 years ago
|
||
It's probably better to file a new bug for comment 20, to avoid this bug from getting too confusing, since a patch already landed and was uplifted.
Comment 22•9 years ago
|
||
OK, happy to do that.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•