Ryan VanderMeulen [:RyanVM] Reporter
	Description • 9 years ago

All you get now is a grey viewport and no cube. mozregression says this was caused by bug 1168263.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 1 • 9 years ago

The regression range is in 45, so if we get the fix, let's make sure we fix it there as well.

	Matt Woodrow (:mattwoodrow) Assignee
	Comment 3 • 9 years ago

This happens when the perspective isn't being applied to the root of the preserve-3d chain. It's a bit weird that the spec allows this, but it does, and apparently websites are relying on it.

This adds a reftest that reproduces the issue.

	Thinker Li [:sinker]
	Comment 5 • 9 years ago

Comment on attachment 8699305 [details] [diff] [review]
Propagate preserve-3d handling through nsDisplayPerspective

Hi Mat, bug 1226904 has changed something.  Could you rebase to it?

	Sylvestre Ledru [:Sylvestre]
	Comment 7 • 9 years ago

Regression, tracking.

	Pulsebot
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c63771a9d4d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/00afe8c23782

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c63771a9d4d2
https://hg.mozilla.org/mozilla-central/rev/00afe8c23782

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 11 • 9 years ago

Working great again, thanks! Please nominate this for Aurora uplift whenever you're comfortable doing so.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 12 • 9 years ago

This patch is needed to fix bug 1222990 which is now a wontfix for Fx44 but if nominated for uplift (also mentioned by RyanVM in the previous comment) to Aurora, we can fix it in Fx45.

	Thinker Li [:sinker]
	Comment 13 • 9 years ago

I agree! This patch is worth to be uplifted.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 14 • 9 years ago

(In reply to Thinker Li [:sinker] from comment #13)
> I agree! This patch is worth to be uplifted.

Thanks! Can you nominate for uplift to Aurora in that case?

	Matt Woodrow (:mattwoodrow) Assignee
	Comment 15 • 9 years ago

Comment on attachment 8706188 [details] [diff] [review]
Propagate preserve-3d handling through nsDisplayPerspective

Approval Request Comment
[Feature/regressing bug #]: Bug 1168263.
[User impact if declined]: Missing content on some 3d demos
[Describe test coverage new/current, TreeHerder]: Tested manually, verified, reftest added.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 17 • 9 years ago

The change that caused this regression was backed out from Firefox 45.

https://hg.mozilla.org/releases/mozilla-aurora/rev/64ec448f156d