Closed
Bug 1230950
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Result is not floating-point] Function nsCSSRendering::PaintBorderWithStyleBorder from nsCSSRendering.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | affected |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1328744)
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review-
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added that the following codes:
>> Float borderWidths[4] = { Float(border.top / twipsPerPixel),
>> Float(border.right / twipsPerPixel),
>> Float(border.bottom / twipsPerPixel),
>> Float(border.left / twipsPerPixel) };
will populate borderWidths with results that are casted to int and loosing precision.
This behavior is present only when NS_COORD_IS_FLOAT is not defined.
|
Assignee | |
Comment 1•9 years ago
|
||
Hello David,
Can you please take a look at this patch?
THX
Attachment #8696468 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff
Review of attachment 8696468 [details] [diff] [review]:
-----------------------------------------------------------------
because David is probably busy.
Attachment #8696468 -
Flags: review?(dbaron) → review?(bzbarsky)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff
Please ask for review from whoever wrote or reviewed this code...
Attachment #8696468 -
Flags: review?(bzbarsky)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8696468 [details] [diff] [review]
Bug 1230950.diff
This seems like a substantive change in behavior, and I strongly suspect we want the current behavior (flooring to an integral number of pixels).
Attachment #8696468 -
Flags: review-
|
|
Assignee | |
Comment 5•9 years ago
|
||
Thx David i will wave the issue from Coverity.
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•