Closed
Bug 1231130
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Uninitialized scalar field] Function nsPluginTag::nsPluginTag from nsPluginTags.h
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox45 affected, firefox47 fixed)
RESOLVED
FIXED
mozilla47
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1327956)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added that mHadLocalInstance is not initialized in the constructor, thus containing garbage value.
|
Assignee | |
Comment 1•9 years ago
|
||
Hello Josh, Can you please take a look other this patch? THX
Attachment #8696682 -
Flags: review?(jaas)
Comment on attachment 8696682 [details] [diff] [review] Bug 1231130.diff Review of attachment 8696682 [details] [diff] [review]: ----------------------------------------------------------------- This looks good but there is are three nsPluginTag constructors in that file. The first already initializes mHadLocalInstance. Your patch fixes the third, but the second one doesn't initialize mHadLocalInstance either - why didn't you fix the second one?
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8716205 -
Flags: review?(jaas)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8696682 -
Attachment is obsolete: true
Attachment #8696682 -
Flags: review?(jaas)
Attachment #8716205 -
Flags: review?(jaas) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
has problems to apply: Hunk #1 succeeded at 263 with fuzz 2 (offset 1 lines). Hunk #2 FAILED at 295 1 out of 2 hunks FAILED -- saving rejects to file dom/plugins/base/nsPluginTags.cpp.rej
Flags: needinfo?(bogdan.postelnicu)
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•9 years ago
|
||
pushed it to mozilla-inbound, thank you Carsten
Flags: needinfo?(bogdan.postelnicu)
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/430e054e6a0f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•