Closed Bug 1231155 Opened 9 years ago Closed 9 years ago

[BACKEND] Make localstorage entry rows editable via double-click in storage inspector

Categories

(DevTools :: Storage Inspector, defect)

Product:
DevTools
Component:
Storage Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro
(deleted), text/x-review-board-request
pbro
: review+
Details
No description provided.
Summary: Make localstorage entry rows editable via double-click in storage inspector → [BACKEND] Make localstorage entry rows editable via double-click in storage inspector
Comment on attachment 8732257 [details] MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41059/diff/1-2/
Comment on attachment 8732257 [details] MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41059/diff/2-3/
Blocks: 1231438
Assignee: nobody → mratcliffe
Blocks: 1260380
Comment on attachment 8732257 [details] MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro https://reviewboard.mozilla.org/r/41059/#review39439 The code changes are really simple, and apart from a couple of minor comments (below), I don't see any problem with them. I just would like to note however that the columns are changing sizes sort of randomly when entering edit mode and tabbing through cells. We've discussed this before, but I just would like to bring it to your attention again because it's pretty anoying when editing storage values and we should look into fixing this pretty soon before the next release point. Setting fixed dimensions on the columns would help (using % units of the table container maybe). ::: devtools/client/storage/test/storage-localstorage.html:4 (Diff revision 3) > +<!doctype html> > +<html> > + <!-- > + Bug 970517 - Storage inspector front end - tests I guess this comment should rather link to bug 1231155 instead. ::: devtools/server/actors/storage.js:1056 (Diff revision 3) > + editItem: method(Task.async(function*(data) { > + let {host, field, oldValue} = data; Since you're already destructuring data, you might as well define `items` in there too, and maybe do this directly in the signature: `function*({host, field, oldValue, items})`
Attachment #8732257 - Flags: review?(pbrosset) → review+
Quick comment, you should change the commit message from Bug 1231155 - [BACKEND] Make localstorage entry rows editable via double-click in storage inspector r?pbro to Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro
https://reviewboard.mozilla.org/r/41059/#review39439 > Since you're already destructuring data, you might as well define `items` in there too, and maybe do this directly in the signature: > > `function*({host, field, oldValue, items})` OMG: I can't believe I didn't do that.
Comment on attachment 8732257 [details] MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41059/diff/3-4/
Attachment #8732257 - Attachment description: MozReview Request: Bug 1231155 - [BACKEND] Make localstorage entry rows editable via double-click in storage inspector r?pbro → MozReview Request: Bug 1231155 - Make localstorage entry rows editable via double-click in storage inspector r=pbro
https://hg.mozilla.org/mozilla-central/rev/7a71674ba4dd
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: