Closed
Bug 1231378
Opened 9 years ago
Closed 9 years ago
Fix uninitialized members of classes - patches ready to land
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: baku, Assigned: baku)
References
Details
(Keywords: sec-other, Whiteboard: [post-critsmash-triage][adv-main46-])
Attachments
(5 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1217756 +++ I split bug 1217756 in order to land some of the patches I pushed without having the clang-plugin patch ready.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
These patches have been reviewed in the previous bug. smaug, are you OK with landing them?
Flags: needinfo?(bugs)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Fix uninitialized members of classes → Fix uninitialized members of classes - patches ready to land
|
||
Comment 7•9 years ago
|
||
Should be fine. Some of the changes may be a bit bogus if ctor calls Reset or some such, but this is good practice anyhow.
Flags: needinfo?(bugs)
|
||
Comment 8•9 years ago
|
||
backed out all patches here and bustage follow up for ongoing bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=19653201&repo=mozilla-inbound
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(amarchesini)
|
|
||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/72fbfd236d8b https://hg.mozilla.org/mozilla-central/rev/824b152131b6 https://hg.mozilla.org/mozilla-central/rev/d8a738e7b8ff https://hg.mozilla.org/mozilla-central/rev/5f773a189557 https://hg.mozilla.org/mozilla-central/rev/b44a63b7a981
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•9 years ago
|
Group: dom-core-security → core-security-release
|
||
Comment 10•9 years ago
|
||
huh, this bug is to back patches out? there is no history of the patches landing? :baku, can you please explain and point me to when this originally landed and what was backed out. With no history in this bug I cannot explore myself. I am tracking down a performance regression.
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Comment 11•9 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #10) > huh, this bug is to back patches out? there is no history of the patches > landing? Not really. This bug is about landing all the patches as comment 9 shows. Here the push to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/72fbfd236d8b https://hg.mozilla.org/integration/mozilla-inbound/rev/824b152131b6 https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a738e7b8ff https://hg.mozilla.org/integration/mozilla-inbound/rev/5f773a189557 https://hg.mozilla.org/integration/mozilla-inbound/rev/b44a63b7a981
Flags: needinfo?(amarchesini)
|
||
Updated•8 years ago
|
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
|
||
Updated•8 years ago
|
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main46-]
|
|
||
Updated•8 years ago
|
Group: core-security-release
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•