Closed Bug 1231404 Opened 9 years ago Closed 9 years ago

SubscriptBaselineDropMin or SuperscriptBaselineDropMax are not read from the MATH table

Categories

(Core :: MathML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

()

Details

Attachments

(1 file, 1 obsolete file)

These parameters were forgotten in bug 961365. They should be used instead of GetSubDropFromChild and GetSupDropFromChild, when available.
Attached patch Patch (obsolete) (deleted) — Splinter Review
It seems that the old code uses the metrics of the scripts rather than those of the mmultiscripts element itself (as we do for getMathConstant). I'm not sure exactly what's the proper exact way to do that? And probably the same question arise for other parameters...
Attachment #8697040 - Flags: feedback?(khaledhosny)
Attachment #8697040 - Flags: feedback?(jfkthame)
I never found a satisfying answer for this question, may be it is worth asking on the OpenType mailing list. My gut feeling is that reading the constants from the base font is the logical choice, testing against MS implementation might be a way to check this.
Attachment #8697040 - Flags: feedback?(khaledhosny) → feedback+
Thanks, I'm not exactly sure what you mean by the "base" font (the one of the <math> root ; or of the <mmultiscripts>, which also has the same size of its base by default). So I'll probably do as in the present patch, as it is consistent with what we do with other constants right now.
Attached patch Patch V2 (deleted) — Splinter Review
Attachment #8697040 - Attachment is obsolete: true
Attachment #8697040 - Flags: feedback?(jfkthame)
Attachment #8702140 - Flags: review?(karlt)
Attachment #8702140 - Flags: review?(jfkthame)
Comment on attachment 8702140 [details] [diff] [review] Patch V2 Review of attachment 8702140 [details] [diff] [review]: ----------------------------------------------------------------- Code seems fine to me (I didn't try it to see if it looks reasonable with the various math fonts, but I assume you're happy with the results it gives).
Attachment #8702140 - Flags: review?(jfkthame) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Attachment #8702140 - Flags: review?(karlt)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: