Adrian Florinescu [:aflorinescu] Reporter
	Description • 9 years ago

Steps:
1. Create tab groups in 44 version.
2. Upgrade to 45.
3. Uninstall 45 and reinstall 44.

Actual Result:
Panorama data doesn't exist anymore.

Expected Result:
I believe it's questionable if the panorama data should be available in this kind of downgrading scenario. From technical point of view I don't expect that the profile is still able to manage panorama after these steps.
However, I think we need to take in consideration the users that will downgrade in order to still use it.

There's also the backup .json we're saving, which might be misleading, although I don't have information related on how exactly this backup is going to be used.

	Adrian Florinescu [:aflorinescu] Reporter
	Comment 1 • 9 years ago

Any thoughts on this?

	Luís Miguel [:quicksaver] (not reading bugmail)
	Comment 2 • 9 years ago

(In reply to Adrian Florinescu from comment #0)
> However, I think we need to take in consideration the users that will
> downgrade in order to still use it.
> 
> There's also the backup .json we're saving, which might be misleading,
> although I don't have information related on how exactly this backup is
> going to be used.

I believe using "replacement" add-ons for both of those things, such as the ones linked in the SUMO removal link [1], will be much more common (and IMO better) than downgrading Firefox.

[1] http://support.mozilla.org/kb/tab-groups-removal

	:Gijs (he/him)
	Comment 3 • 9 years ago

(In reply to Adrian Florinescu from comment #0)
> Steps:
> 1. Create tab groups in 44 version.
> 2. Upgrade to 45.
> 3. Uninstall 45 and reinstall 44.
> 
> Actual Result:
> Panorama data doesn't exist anymore.
> 
> Expected Result:
> I believe it's questionable if the panorama data should be available in this
> kind of downgrading scenario. From technical point of view I don't expect
> that the profile is still able to manage panorama after these steps.
> However, I think we need to take in consideration the users that will
> downgrade in order to still use it.
> 
> There's also the backup .json we're saving, which might be misleading,
> although I don't have information related on how exactly this backup is
> going to be used.

You could copy the backup file into sessionstore.js and/or previous.js to get back the tab groups data, if you do downgrade (or, for instance, keep using 38 ESR for longer, or accidentally used a release profile with nightly for one startup).

We remove the tab groups data from the session store file because if you have 500 hidden tabs with all their session information that you can't even access, that's not great for file read performance or for the performance of some of our tabbrowser code, or for your privacy (because here's all this data that you can't see but is still there).

So I don't think we need to do anything here. I think removing the data is correct, there are avenues (like backups and the add-ons etc.) to get your things. I did also bring this up with UX and other engineers, and I believe that this is expected by them, too.

As a consequence, going to mark wontfix.