Closed Bug 1231414 Opened 9 years ago Closed 6 years ago

RTCPeerConnection.addTrack should not require a stream to be passed

Categories

(Core :: WebRTC, defect, P2)

Product:
Core
Component:
WebRTC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox45 --- wontfix
firefox67 --- fixed

People

(Reporter: bzbarsky, Assigned: bwc)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [spec])

Attachments

(2 files)

Bug 1231414 - Part 1: Allow addTrack without a stream argument. r?jib,smaug
(deleted), text/x-phabricator-request
Details
Bug 1231414 - Part 2: Mark some wpt as expected to succeed. r?jib
(deleted), text/x-phabricator-request
Details
Per https://github.com/w3c/webrtc-pc/issues/288 calling addTrack with no streams should be OK.
Component: DOM → WebRTC
Rank: 25
Priority: -- → P2
Whiteboard: [spec]
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Rank: 25 → 15
Priority: P3 → P2

This is turning into a major headache with web-platform-tests, requiring lots of tests (that aren't really testing addTrack) to be disabled.

Assignee: nobody → docfaraday

Depends on D19841

Review ping.

Flags: needinfo?(jib)

All reviews here look accepted.

Flags: needinfo?(jib)
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/918f7a08c59b Part 1: Allow addTrack without a stream argument. r=jib,smaug https://hg.mozilla.org/integration/autoland/rev/6be475d0d9b8 Part 2: Mark some wpt as expected to succeed. r=jib

https://hg.mozilla.org/mozilla-central/rev/918f7a08c59b
https://hg.mozilla.org/mozilla-central/rev/6be475d0d9b8

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Documentation updated:

I've made substantial revisions to the article on addTrack() to cover this and to explain in more detail the relationship between the tracks and streams across a peer connection. This would definitely benefit from a review:

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addTrack

I've also made affiliated revisions to the following articles. Some are error corrections, some are clarifications, and there are a few additions of missing details:

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/addStream
https://developer.mozilla.org/en-US/docs/Web/API/MediaStream/MediaStream
https://developer.mozilla.org/en-US/docs/Web/API/RTCTrackEvent

Since this is a bug fix, I don't think it warrants a BCD update. If there's disagreement, it could be added as a note -- I'm not sure adding a "feature" row for this makes sense given that it's a bug fix.

Added to Firefox 67 for developers.

Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: