Closed
Bug 1231553
Opened 9 years ago
Closed 9 years ago
Inset shadow makes most of the notification bar dark
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: Mardak, Assigned: mancas)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
dec 7, dec 8 builds
Bug 1227216 was recently fixed which was causing some shadow oddness since november 22.
Bug 1214214 landed while the graphics bug existed, so the inset border appeared okay.
I've attached screenshots of builds from dec 7 (graphics bug not fixed) and dec 8 (graphics fixed).
|
||
Comment 1•9 years ago
|
||
I'm confused, does that mean this bug is fixed since bug 1227216? Thanks!
Flags: needinfo?(edilee)
|
Reporter | |
Comment 2•9 years ago
|
||
No, this bug exists because it relied on the regressed behavior that was correctly fixed by bug 1227216.
I believe bug 1214214 didn't actually want a 40px inset box shadow.
Flags: needinfo?(edilee)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → b.mcb
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8697272 -
Flags: review?(mdeboer)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8697272 [details] [diff] [review]
Inset shadow makes most of the notification bar dark
Review of attachment 8697272 [details] [diff] [review]:
-----------------------------------------------------------------
Looking good! Thanks for the demo :)
Attachment #8697272 -
Flags: review?(mdeboer) → review+
|
||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•