Closed
Bug 1231557
Opened 9 years ago
Closed 9 years ago
Audio and video elements don't use the URL classifier
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: francois, Assigned: francois)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
cpearce
:
review+
gcp
:
review+
|
Details | Diff | Splinter Review |
Because the audio and video elements open a channel without the nsIChannel::LOAD_CLASSIFY_URI loadflag, the tracking protection list doesn't apply to them.
Assignee | ||
Updated•9 years ago
|
Component: DOM: Security → Safe Browsing
Product: Core → Toolkit
Assignee | ||
Comment 1•9 years ago
|
||
This patch works, but I'm not sure we need to classify the channel in those three call sites. The dom/html/HTMLMediaElement one seems to be the only one that matters.
Attachment #8697239 -
Flags: feedback?(cpearce)
Comment 2•9 years ago
|
||
Comment on attachment 8697239 [details] [diff] [review]
bug1231557.patch
Review of attachment 8697239 [details] [diff] [review]:
-----------------------------------------------------------------
I think we're better off adding the flag to all of our call sites, otherwise a site could load a video to a URL that on first load that doesn't track, and then seek the video, causing us to hit the recreate-channel path, which the server could redirect to a URL which *does* track.
Attachment #8697239 -
Flags: feedback?(cpearce) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8697239 -
Attachment is obsolete: true
Attachment #8697819 -
Flags: review?(gpascutto)
Attachment #8697819 -
Flags: review?(cpearce)
Updated•9 years ago
|
Attachment #8697819 -
Flags: review?(cpearce) → review+
Updated•9 years ago
|
Attachment #8697819 -
Flags: review?(gpascutto) → review+
Comment 5•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•