Closed Bug 1231661 Opened 9 years ago Closed 9 years ago

Relax no-multi-spaces Eslint rule

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

I think we should support cases like: var a = 1; var ab = 2; this.a = 1; this.ab = 2; let a = [[1, 0, 1 ], [0, 10, 0 ], [0, 1, 100 ]] let o = { a: 1 ab: 2 } the current no-multi-space is just too strict and raises a lot of errors in the codebase.
Summary: Relax no-multi-space Eslint rule → Relax no-multi-spaces Eslint rule
Bug 1231661 - Relax no-multi-spaces Eslint rule. r=Mossop
Attachment #8697315 - Flags: review?(dtownsend)
Comment on attachment 8697315 [details] MozReview Request: Bug 1231661 - Relax no-multi-spaces Eslint rule. r=Mossop https://reviewboard.mozilla.org/r/27555/#review24837 ::: toolkit/.eslintrc:104 (Diff revision 1) > - // "no-multi-spaces": 2, > + // no-multi-spaces: [2, { exceptions: { "ImportDeclaration": true, "AssignmentExpression": true, "VariableDeclarator": true, "ArrayExpression": true } }], Do we need ImportDeclaration?
Attachment #8697315 - Flags: review?(dtownsend) → review+
Comment on attachment 8697315 [details] MozReview Request: Bug 1231661 - Relax no-multi-spaces Eslint rule. r=Mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27555/diff/1-2/
removed the import exception since for now we don't use it, we can always add it in future, when needed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: