Closed
Bug 1231945
Opened 9 years ago
Closed 9 years ago
Display animation ID in the animation inspector timeline
Categories
(DevTools :: Inspector: Animations, defect)
DevTools
Inspector: Animations
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
(Whiteboard: [devtools-platform])
Attachments
(1 file)
In the animation timeline, each displayed animation has got a name label.
For css animations it's the @keyframes rule name.
For css transitions it's the transitioned property.
The WebAnimations API also introduces JS-generated animations and that's being implemented now. These can get an ID defined by authors.
Using the API, authors can also set IDs for CSS animations.
So, we should change the way the animation name is retrieved in the AnimationPlayerActor so that, if there's an ID, then use this.
Assignee | ||
Updated•9 years ago
|
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → pbrosset
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33235/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33235/
Attachment #8714733 -
Flags: review?(ttromey)
Assignee | ||
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Attachment #8714733 -
Flags: review?(ttromey) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8714733 [details]
MozReview Request: Bug 1231945 - Display animation.id when it exists; r=tromey
https://reviewboard.mozilla.org/r/33235/#review29997
Looks great.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•