Closed Bug 1232151 Opened 9 years ago Closed 8 years ago

Master password prompt is opened several times when there are concurrent password requests

Categories

(Core Graveyard :: Security: UI, defect)

42 Branch
defect
Not set
normal

Tracking

(firefox45 affected)

RESOLVED DUPLICATE of bug 177175
Tracking Status
firefox45 --- affected

People

(Reporter: alex, Unassigned, NeedInfo)

References

Details

Attachments

(2 files, 1 obsolete file)

(deleted), text/html
Details
(deleted), application/x-xpinstall
Details
The master password prompt is opened several times when there are concurrent password requests. In the following example the password is required for a websites login form and an Add-on worker on the same site. Steps to reproduce: 1. Set up any master password if you do not have one 2. Open testcase.html in Firefox, enter any username and password and click "Login" 3. When Firefox asks "Would you like Firefox to remember this login?" click "Remember" 4. Close the testcase.html tab 5. Install the Add-on testcase.xpi (it is signed, you can unzip it to see its contents) 6. Close and reopen Firefox but do not enter the master password yet 7. Open testcase.html Expected result: The master password prompt appears. After typing in my correct master password no additional prompt should show up. Actual result: The master password prompt appears. After typing in my correct master password the login data gets filled in on the website (testcase.html) and the callback of the Add-on returns. The problem: At the same time another master password prompt appears. I've published a small Add-on that faces this problem in production: https://addons.mozilla.org/firefox/addon/fau-auto-login/
Attached file testcase.html (deleted) —
This is the testcase.html with a simple login form.
Attached file testcase.xpi (obsolete) (deleted) —
This is the testcase.xpi that will trigger the second, concurrent password manager request. IMPORTANT: You have to download testcase.html because this Add-on matches an URL that begins with "file:///" and ends with "testcase.html".
Attached file testcase.xpi (deleted) —
Attachment #8697807 - Attachment is obsolete: true
I've tested the following setups: - Firefox 45 Nightly on OS X 10.11.2 - Firefox 45 Nightly on Ubuntu 14.04.3 - Firefox 45 Nightly on Windows 10 - Firefox for Android 45 Nightly on Android 5.0 - Firefox 42 Release on OS X 10.11.2 - Firefox 42 Release on Windows 10 All are affected. After typing in the master password for the first time, the JavaScript callback function inside the Add-on gets called. After typing in the master password for the second time the credentials are filled in. For each time you press cancel one step doesn't get executed. This test case behavior differs slightly from my Add-on behavior (which is linked above) where both things are executed after the first time I filled in the master password. Still, the prompt is displayed twice.
OS: Unspecified → All
Hardware: Unspecified → All
Version: 45 Branch → 42 Branch
is there a reason this shouldn't be marked a dupe of bug 177175?
Flags: needinfo?(alex)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: