Closed Bug 1232335 Opened 9 years ago Closed 9 years ago

Autophone - Mdm failure - dom/media/test/test_can_play_type_mpeg.html

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed, fennec+)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed
fennec + ---

People

(Reporter: bc, Assigned: esawin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

https://treeherder.allizom.org/#/jobs?repo=try&exclusion_profile=false&group_state=expanded&author=bclary@mozilla.com Samsung Galaxy S3 Android 4.0 >159 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4='' - got "maybe", expected "" >161 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | audio/mp4='' - got "maybe", expected "" >167 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42E01E, mp4a.40.2"='' - got "probably", expected "" >169 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42001E, mp4a.40.2"='' - got "probably", expected "" >171 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401E, mp4a.40.2"='' - got "probably", expected "" >172 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401F, mp4a.40.2"='' - got "probably", expected "" >176 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42E01E"='' - got "probably", expected "" >177 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42001E"='' - got "probably", expected "" >179 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401E"='' - got "probably", expected "" >181 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs="mp4a.40.2"='' - got "probably", expected "" >182 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs=mp4a.40.2='' - got "probably", expected "" >190 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | audio/mpeg='' - got "maybe", expected "" Only available in my local Autophone instance. If you would like to test patches, do a try build and ping me and I will run it locally. If you don't care about this, please just mark it WONTFIX.
Blocks: 1232336
No longer blocks: 1232336
Assignee: nobody → esawin
tracking-fennec: ? → +
Attached patch bug-1232335.patch (obsolete) (deleted) — Splinter Review
esawin, I ran a test with your patch and my patch from bug 1237465 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e8ae92a686d&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false nexus-s-4 is showing errors like: > TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | audio/x-m4a; codecs="mp4a.40.5"='probably' - got "", expected "probably" nexus-4-jdq39-4 crashed PROCESS-CRASH | dom/media/test/test_bug1113600.html | application crashed [@ libc.so + 0xd598] nexus-7-jss15q-2 didn't run any tests but that is expected for api 18. nexus-5-kot49h-5 PROCESS-CRASH | dom/media/test/test_bug1113600.html | application crashed [@ pthread_mutex_lock_impl]
The results look like test_can_play_type_mpeg works as intended, passes on all platforms except for Android 2.3, where media supports seems to be actually broken based on my testing on Nexus S.
It turns out, Nexus S has been blacklisted in bug 864734 for OMX. Force-enabling it (pref "stagefright.force-enabled") would make the tests pass, but H.264 video playback shows artifacts, ranging from barely watchable to unwatchable.
This patch fixes the test for all Android versions. The failures with GB on Nexus S are due to OMX blacklisting, so it's not a test issue. I see following options to proceed: 1. Remove the Nexus S blacklisting which would enable media and make this test pass on the device running GB at the risk of crashes/video artifacts (from my tests I've seen H.264 issues, MP3 plays fine, YouTube plays fine but audio gets out of sync). 2. Force-enable OMX support on Nexus S just for tests via pref. 3. Disable this test for API 9-10. Any preferences or other ideas?
Attachment #8706049 - Attachment is obsolete: true
Attachment #8708455 - Flags: review?(snorp)
Disable the test on Gingerbread? Effort-reward tradeoff…
(In reply to Richard Newman [:rnewman] from comment #6) > Disable the test on Gingerbread? Effort-reward tradeoff… I agree, however that would mean we would have no media test coverage on GB only because we're using an unsupported device in automation.
Disable test on Gingerbread.
Attachment #8708455 - Attachment is obsolete: true
Attachment #8708455 - Flags: review?(snorp)
Attachment #8709069 - Flags: review?(snorp)
Attachment #8709069 - Flags: review?(snorp) → review+
Backed out for make the modified test fail. Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc21adab7bf Failure: TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | uncaught exception - ReferenceError: IsAndroid is not defined at http://mochi.test:8888/tests/dom/media/test/test_can_play_type_mpeg.html:137 IsAndroid hasn't been defined yet in that test file.
Flags: needinfo?(esawin)
Rebased on inbound.
Attachment #8709069 - Attachment is obsolete: true
Flags: needinfo?(esawin)
Attachment #8709567 - Flags: review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: