Closed Bug 1232408 Opened 9 years ago Closed 9 years ago

E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 46
Tracking Flags:
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 obsolete file)

My mistake, I had a last minute drive by comment on this and I didn't test the change.
Assignee: nobody → jmathies
Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe
Attachment #8698136 - Flags: review?(felipc)
Comment on attachment 8698136 [details] MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe https://reviewboard.mozilla.org/r/27825/#review24997
Attachment #8698136 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/5b69961c4b35
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8698136 [details] MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe Approval Request Comment [Feature/regressing bug #]: a11y + e10s stability issues work [User impact if declined]: a11y users are gonna have a bad time. [Describe test coverage new/current, TreeHerder]: running in nightly for a couple days. [Risks and why]: we just merged so uplifting this shouldn't be a problem. [String/UUID change made/needed]: no
Attachment #8698136 - Flags: approval-mozilla-aurora?
Comment on attachment 8698136 [details] MozReview Request: Bug 1232408 - E10SAccessibilityCheck relies on incorrect AppConstants variable XP_WIN. r?felipe Needed for "e10s disabled in a11y mode", Aurora45+
Attachment #8698136 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8698136 - Attachment is obsolete: true
[bugday-20160323] Status: RESOLVED,FIXED -> INCOMPLETE Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: