Closed
Bug 1232614
Opened 9 years ago
Closed 9 years ago
JSON Viewer: visual expand[ed] indicators feel a bit old
Categories
(DevTools :: JSON Viewer, defect)
DevTools
JSON Viewer
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
The [+] and [-] indicators on the left of keys with expandable values (objects, arrays) feels like something from older Windows OSes. Maybe use the triangle used in the DevTools inspector's dom tree?
See also:
https://bugzilla.mozilla.org/show_bug.cgi?id=1223143#c7
Honza
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8698400 -
Flags: review?(jryans)
Comment on attachment 8698400 [details] [diff] [review]
bug1232614-1.patch
Review of attachment 8698400 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8698400 -
Flags: review?(jryans) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 5•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•