Closed
Bug 1232677
Opened 9 years ago
Closed 9 years ago
On clean profile nightly startup, tab migration leaves an error in the browser console
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(firefox45 verified, firefox46 verified)
VERIFIED
FIXED
Firefox 46
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jaws
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
STR: 1. Open 45+ on a clean profile ER: no errors AR: Failed to parse sessionstore state JSON to migrate tab groups: SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data We should just ignore an empty file.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws
Attachment #8698450 -
Flags: review?(jaws)
Assignee | ||
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8698450 -
Flags: review?(jaws) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8698450 [details] MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws https://reviewboard.mozilla.org/r/27997/#review25331
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8698450 [details] MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws Approval Request Comment [Feature/regressing bug #]: tab groups migration [User impact if declined]: clean profile startup shows an error in the browser console for 45 [Describe test coverage new/current, TreeHerder]: not for this error and/or this particular method - but all we're adding is an early return in case the data is empty [Risks and why]: very low, see previous point [String/UUID change made/needed]: nope
Attachment #8698450 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad758df8d567
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 6•9 years ago
|
||
Comment on attachment 8698450 [details] MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws Tab migration related issue, taking it.
Attachment #8698450 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1ce623a9f899
Comment 8•9 years ago
|
||
Verified as fixed on Nightly and Aurora builds as follows: Nighlty builds: Windows7 x64: 46.0a1 Build ID 20151228030213 - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 Ubuntu 14.04 x32: 46.0a1 Build ID 20151227030239 - Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0 Mac 10.10: Build ID 20151229030216 - User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:46.0) Gecko/20100101 Firefox/46.0 Aurora builds: Windows 7 x64: 45.0a2 Build ID 20151229004007 - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 Ubuntu 14.04 x32: 45.0a2 Build ID20151228004010 - Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0 Mac 10.10: 45.0a2 Build ID 20151229004007 - User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Firefox/45.0
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•