Closed Bug 1232749 Opened 9 years ago Closed 4 years ago

Unify `android:buttonStyle`s

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned)

References

Details

Attachments

(2 files)

There is a theme attr, android:buttonStyle that we can use to unify the button UI. This article [1] mentions the "Widget.AppCompat.Button.*" style we can use as a base style. In particular, AppCompat capitalizes all of the text in Buttons. This may be undesired and we can override it in the theme with `android:textAllCaps`. bug 1220309 will likely add a workaround in remote_tabs_setup that we should remove if it moves to the base style. We should also check for other work arounds. [1]: http://manuel-ohlendorf.de/blog/2015/09/03/material-design-buttons-with-appcompat/
Attached image Screenshot: original pre-caps (deleted) —
Attached image Screenshot: all caps (deleted) —
I think we should look at this more holistically. That is, where else in our UI does this formatting affect? These buttons are designed only for our about:home view right now. If we're just talking about the about:home panels, then I'd like to go back to sentence casing because right now, it looks too much like we're yelling at the user.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: