Closed
Bug 1232983
Opened 9 years ago
Closed 9 years ago
border-radius/clipping-6.html is failing on linux64 docker container
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla46
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
as we are working towards getting our tests running in taskcluster which uses a docker container, there are main reftest failures in particular. This one is seen on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a238c213d3a&filter-searchStr=r1&selectedJob=14637552
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/border-radius/clipping-6.html | image comparison (==), max difference: 102, number of differing pixels: 124
Looking a the reftest analyzer from treeherder you can see the difference;
http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Og4ayYWjQOC4dwpC3js6Rw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
In addition, you can toggle between each image and see the difference visually.
This test already has a lot of fuzzing around it:
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/border-radius/reftest.list#54
I suspect we will end up doing the same to solve this by adding:
fuzzy-if(gtkWidget,102,124)
For reference we have a lot of other failures (bug 1232316, bug 1232979, bug 1232980, bug 1232981) which we are working on.
Comment 1•9 years ago
|
||
Should we NI for this bug? or not yet?
Assignee | ||
Comment 2•9 years ago
|
||
this is the approach we have used for a few other tests- still waiting on review on them, so this might not be the acceptable solution to use here.
here is what the test looks like with the font change:
http://people.mozilla.org/~jmaher/border-radius.html
Comment 3•9 years ago
|
||
Comment on attachment 8701082 [details] [diff] [review]
add font-size:300 to the body to reduce fuzzy painting
Review of attachment 8701082 [details] [diff] [review]:
-----------------------------------------------------------------
Seems fine, the text is only there to prevent optimizations in layout that happen when the content consists of only solid colours.
Attachment #8701082 -
Flags: review?(matt.woodrow) → review+
Comment 5•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 6•9 years ago
|
||
Moving closed bugs across to new Bugzilla product "TaskCluster".
Updated•6 years ago
|
Component: Integration → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•