Closed
Bug 1233029
Opened 9 years ago
Closed 9 years ago
Installation fails if you click on the "flash device" button until the entire boot sequence is done
Categories
(Firefox OS Graveyard :: B2gInstaller, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: gerard-majax)
References
Details
Attachments
(4 files)
STR
1. Plug a Flame
2. Select nightly
3. Flash
Result
On the UI, the flash operation still ongoing. Nonetheless, WebConsole stopped logging on a failure. I think there is something wrong with my setup. The first time I flashed an eng build with the addon, everything went fine. Then it failed twice, then it passed again. It seems like some files are missing.
It doesn't appear I ran out of disk space or memory.
I didn't flash anything else in the middle of my 4 tries.
See attachments for details.
Repro rate: 2/4 times.
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
> Result
> On the UI, the flash operation still ongoing.
I should precise, in this case, it was the step called "Flashing build"
I also got the same failure during "Downloading blobs from device". Here are the webconsole logs.
Reporter | ||
Comment 3•9 years ago
|
||
After some more investigation and Alexandre's guess, it turns out ADB gets disconnected and reconnected even after the lockscreen is displayed. This is why it fails at adb-related steps.
Then, we need to improve the error message, when this kind of events occur.
Summary: Installing failed (it seems like some files are missing) → Installation failed if you click on the "flash device" button until the entire boot sequence is done
Reporter | ||
Updated•9 years ago
|
Summary: Installation failed if you click on the "flash device" button until the entire boot sequence is done → Installation fails if you click on the "flash device" button until the entire boot sequence is done
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Johan Lorenzo [:jlorenzo] (QA) - On PTO from Dec 23rd to Jan 3rd 2016 from comment #3)
> After some more investigation and Alexandre's guess, it turns out ADB gets
> disconnected and reconnected even after the lockscreen is displayed. This is
> why it fails at adb-related steps.
>
> Then, we need to improve the error message, when this kind of events occur.
If we detect a device running B2G (which is what this is about) we should probably adb shell stop b2g. That will not work, however, on "user" builds.
Assignee | ||
Comment 5•9 years ago
|
||
I suggest we:
- if we have root access, we adb shell stop b2g
- if we don't have root access, we show a dialog to ask the user to disable lockscreen
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #5)
> I suggest we:
> - if we have root access, we adb shell stop b2g
> - if we don't have root access, we show a dialog to ask the user to disable
> lockscreen
I suggest we do this only during the "Flashing" steps of the addon, not before. This way it will avoid running |adb shell stop b2g| on device which just got plugged in and not really requested to flash.
Assignee | ||
Comment 7•9 years ago
|
||
Assignee: nobody → lissyx+mozillians
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8715342 [details]
WIP PR
Should be good to review now :)
Attachment #8715342 -
Flags: review?(dale)
Comment 9•9 years ago
|
||
Comment on attachment 8715342 [details]
WIP PR
Good job
Attachment #8715342 -
Flags: review?(dale) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•