Closed Bug 1233311 Opened 9 years ago Closed 9 years ago

Hang in Android cppunit test reports "%d format: a number is required, not NoneType"

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=879d75dc0d04 forcibly hangs the cppunit test TestAtomics http://archive.mozilla.org/pub/mobile/try-builds/gbrown@mozilla.com-879d75dc0d04d139ddc19852ba64bd9925667092/try-android-api-11-debug/try_ubuntu64_vm_armv7_mobile-debug_test-cppunit-bm120-tests1-linux64-build266.txt.gz 16:44:52 INFO - TEST-START | TestAtomics 16:59:52 INFO - mozdevice Timeout exceeded for shell call 'adb shell export MOZ_CRASHREPORTER=1; export XPCOM_DEBUG_BREAK=stack-and-abort; export MOZ_XRE_DIR=/data/local/tests/cppunittests/b; export TMPDIR=/data/local/tests/cppunittests/tmp; export HOME=/data/local/tests/cppunittests/h; export MOZ_CRASHREPORTER_NO_REPORT=1; export LD_LIBRARY_PATH=/data/local/tests/cppunittests/b; export MOZILLA_FIVE_HOME=/data/local/tests/cppunittests/h; cd /data/local/tests/cppunittests/h; /data/local/tests/cppunittests/b/TestAtomics; echo $?' 16:59:52 INFO - PROCESS | TestAtomics | 16:59:52 INFO - %d format: a number is required, not NoneType 16:59:52 ERROR - Return code: 1 16:59:52 ERROR - No tests run or test summary not found Some logs like this are reported in bug 1160010.
Attached patch allow for returncode of None (deleted) — Splinter Review
Note that devicemanager.shell() can return None. Now a time-out is reported much better: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea2c85dd11ca&selectedJob=14686026 22:41:26 INFO - TEST-START | TestAtomics 22:56:26 INFO - mozdevice Timeout exceeded for shell call 'adb shell export MOZ_CRASHREPORTER=1; export XPCOM_DEBUG_BREAK=stack-and-abort; export MOZ_XRE_DIR=/data/local/tests/cppunittests/b; export TMPDIR=/data/local/tests/cppunittests/tmp; export HOME=/data/local/tests/cppunittests/h; export MOZ_CRASHREPORTER_NO_REPORT=1; export LD_LIBRARY_PATH=/data/local/tests/cppunittests/b; export MOZILLA_FIVE_HOME=/data/local/tests/cppunittests/h; cd /data/local/tests/cppunittests/h; /data/local/tests/cppunittests/b/TestAtomics; echo $?' 22:56:26 INFO - PROCESS | TestAtomics | 22:56:26 WARNING - TEST-UNEXPECTED-FAIL | TestAtomics | test failed with return code None 22:56:26 INFO - TEST-INFO took 900343ms and the star-able message includes the test name -- "TEST-UNEXPECTED-FAIL | TestAtomics | test failed with return code None" -- which should avoid having all such time-outs reported to bug 1160010.
Attachment #8699492 - Flags: review?(jmaher)
Comment on attachment 8699492 [details] [diff] [review] allow for returncode of None Review of attachment 8699492 [details] [diff] [review]: ----------------------------------------------------------------- so simple
Attachment #8699492 - Flags: review?(jmaher) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: