Review commit: https://reviewboard.mozilla.org/r/28271/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28271/

Comment on attachment 8699539 [details] MozReview Request: Bug 1233470 - make browser/modules eslintable, r?Mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28271/diff/1-2/

Comment on attachment 8699539 [details] MozReview Request: Bug 1233470 - make browser/modules eslintable, r?Mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28271/diff/2-3/

Did we not turn on the windows line endings rule? browser/modules/test/browser_BrowserUITelemetry_buckets.js seems to be using them, but eslint didn't mention it. I converted it to unix in the latest revision of this patch anyway, but...

Comment on attachment 8699539 [details] MozReview Request: Bug 1233470 - make browser/modules eslintable, r?Mossop https://reviewboard.mozilla.org/r/28271/#review25337 Awesome, thanks ::: browser/modules/Social.jsm:142 (Diff revision 3) > + p.enabled = enable; providers already check whether they are enabled so you can just blindly set p.enabled to enabled and save a check.

[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected