Closed
Bug 1234095
Opened 9 years ago
Closed 9 years ago
Rework animation sorting to support script-generated animations
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
This involves:
* Reworking CSSAnimation::HasLowerCompositeOrderThan to support generic animations[1]
* Reworking Animation::HasLowerCompositeOrderThan to handle the case when aOther provides some other sort of prioritization.
[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/layout/style/nsAnimationManager.cpp#134
|
Assignee | |
Comment 1•9 years ago
|
||
Here's an initial attempt at this. I don't really like that Animation needs knowledge of CSSTransition and CSSAnimation, but I think it's better than the previous arrangement at least.
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8707259 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8707333 [details] [diff] [review]
Rework sorting to handle to script-generated animations
Thanks for all the reviews lately. I'll try to make this the last one for this week!
Attachment #8707333 -
Flags: review?(cam)
|
||
Updated•9 years ago
|
Attachment #8707333 -
Flags: review?(cam) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•