Closed
Bug 1234472
Opened 9 years ago
Closed 9 years ago
Add gonk sideband stream handling to gfx ipc
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
native_handle_t is necessary to support SidebandStream
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
GonkNativeHandle imitates FenceHandle's implementation.
native_handle_t is defined in the following
http://androidxref.com/6.0.0_r1/xref/system/core/include/cutils/native_handle.h#24
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> Created attachment 8701016 [details] [diff] [review]
> patch - Add GonkNativeHandle
Implemantations of ParamTraits<GonkNativeHandle>::Write() and ParamTraits<GonkNativeHandle>::Read() refer android's Parcel::writeNativeHandle() and Parcel::readNativeHandle().
http://androidxref.com/6.0.0_r1/xref/frameworks/native/libs/binder/Parcel.cpp#854
http://androidxref.com/6.0.0_r1/xref/frameworks/native/libs/binder/Parcel.cpp#1338
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8701016 -
Attachment is obsolete: true
Assignee | ||
Comment 6•9 years ago
|
||
Update ImageClientSingle::UpdateImage()
Attachment #8703927 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8703932 -
Flags: review?(nical.bugzilla)
Comment 7•9 years ago
|
||
Comment on attachment 8703932 [details] [diff] [review]
patch - Add GonkNativeHandle
Review of attachment 8703932 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/ipc/GonkNativeHandle.h
@@ +18,5 @@
> +namespace mozilla {
> +namespace layers {
> +
> +#ifdef MOZ_WIDGET_GONK
> +class GonkNativeHandle {
Please add a quick comment about what this is useful for (a rough summary of what sideband stream is would be nice too, I had to look it up in android's source to figure it out)
Attachment #8703932 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Apply the comment.
Attachment #8703932 -
Attachment is obsolete: true
Attachment #8704412 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Summary: Add native_handle_t support on gecko ipc → Add gonk sideband stream handling to gfx ipc
Assignee | ||
Comment 9•9 years ago
|
||
Fix build failure. Carry "r=nical".
Attachment #8704412 -
Attachment is obsolete: true
Attachment #8704455 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee | ||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•