Closed
Bug 1234912
Opened 9 years ago
Closed 9 years ago
Provide better error message and suggest to run `mach mercurial-setup` if |mach artifact| fails with Mercurial pushhead error
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: nalexander, Unassigned)
References
Details
Attachments
(1 file)
`mach artifact install` requires the `pushhead` revlog extension, which is provided by a Firefox-specific hg extension. We don't do a great job documenting this, and we don't help a user who's not configured get configured. This ticket tracks doing better.
Reporter | ||
Comment 1•9 years ago
|
||
rnewman saw this. mhammoud provides the following screencap of the error in #mobile: http://i.imgur.com/Jt8OXhm.png
Reporter | ||
Comment 2•9 years ago
|
||
To fix this, we need to handle errors around https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#193. We might consider running `hg` once just to test the extensions are available; or we might just try to parse this particular error out and link to documentation.
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29841/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29841/
Attachment #8704971 -
Flags: review?(gps)
Comment 4•9 years ago
|
||
Comment on attachment 8704971 [details]
MozReview Request: Bug 1234912 - Check for |mozext| after |mach artifact install| hg failure. r?gps
https://reviewboard.mozilla.org/r/29841/#review26773
::: python/mozbuild/mozbuild/artifacts.py:415
(Diff revision 1)
> + raise Exception('Could not find candidate pushheads. Enable the "mozext" hg extension.')
Can you make this message actionable? Provide a URL to instructions or just print the instructions inline.
Attachment #8704971 -
Flags: review?(gps) → review+
Reporter | ||
Comment 5•9 years ago
|
||
Reporter | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/98623463f9b9e879767add7103fa10dbd470fb50
Bug 1234912 - Check for mozext and pushlog entries after |mach artifact install| hg failure. r=gps
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•