Open Bug 1234988 Opened 9 years ago Updated 2 years ago

APZ scrolling doesn't work during a CSS animation that forces changes to the scroll position

Categories

(Core :: Panning and Zooming, defect, P5)

48 Branch
defect

Tracking

()

Tracking Status
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- fix-optional
firefox51 --- fix-optional

People

(Reporter: arni2033, Unassigned)

References

Details

(Keywords: correctness, regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20151223030323
STR:
1. Make sure that mouse option "When I rotate the mouse wheel" in your OS is set to  "scroll by 1 page"
2. Open attached "testcase 1" with slow animation
3. Press End to scroll the page to the bottom
4. Scroll mouse wheel up once
You must perform Steps 2-4 within 90 seconds.

Result:       
 The page twitches a bit, but Step 4 doesn't seem to do anything
 [request a screencast if necessary]

Expectations: 
 The page should be scrolled up

This was regressed between 2015-12-02 and 2015-12-03 by bug 1228028
> pushlog_url:   https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0dbac1acaca7ae2a767604fdbcf5105853518c88&tochange=f7ee42669b87f05416eb785ab9db27b5c66de1a3
I can reproduce the scroll problem with default mouse wheel amount(3 lines/a single tick).

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=738d8ee106fe&tochange=af67b5f73381

Regressed by af67b5f73381	Kartikaya Gupta — Bug 1157745 - Enable APZ on Windows desktop nightly builds. r=dvander
Blocks: apz-windows
The problem here is a variant of the problem in bug 1228407. What's happening is that the CSS animation is actually shortening the page very slowly. When you're scrolled to the very bottom, that means the scroll offset needs to move upwards to compensate for the page getting shorter. The main thread takes care of this by sending a flood of scroll position updates to the APZ, which keeps the scroll generation incrementing continuously and prevents APZ from doing any updates to the scroll offset. When you're not at the bottom of the page, the main thread doesn't need to keep updating the scroll offset and so this problem doesn't happen.

Need to think of a good fix to this that's more robust than what we did in bug 1228407.
Assignee: nobody → bugmail.mozilla
(And yes, this isn't specific to page scrolling, I was able to repro with line scrolling. Also it's a bit of an edge case so I won't block APZ on it).
Blocks: apz-desktop
No longer blocks: 1228028
Has STR: --- → yes
Assignee: bugmail.mozilla → nobody
Summary: Page scrolling with APZ doesn't work in some cases → APZ scrolling doesn't work during a CSS animation that forces changes to the scroll position
Keywords: correctness
Whiteboard: [gfx-noted]
Assignee: nobody → bugmail.mozilla
Marking as wontfix for 46; even if we fix it in Nightly I doubt we would uplift the fix to Beta.
Not worth uplifting when we do fix it.
Assignee: bugmail.mozilla → nobody
Priority: -- → P5
Bumping again, low priority.
Version: Trunk → 48 Branch
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: