Closed Bug 1235124 Opened 9 years ago Closed 9 years ago

[Presentation WebAPI] Start multi-screen by Presentation API

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kuoe0.tw, Assigned: kuoe0.tw)

References

Details

Attachments

(1 file)

[gaia] KuoE0:multi-screen > mozilla-b2g:master
(deleted), text/x-github-pull-request
lchang
: review+
lchang
: feedback+
Details
We'll integrate multi-screen into Presentation API as the 1-UA (user-agent) use case. And it'll be the only way to start multi-screen mode currently.
Comment on attachment 8701975 [details] [gaia] KuoE0:multi-screen > mozilla-b2g:master Hi Luke, can you give me some feedback on this patch? I thinks we don't need the preference to enable multi-screen now. So, I remove the code of it.
Attachment #8701975 - Flags: feedback?(lchang)
Assignee: nobody → kuoe0
Comment on attachment 8701975 [details] [gaia] KuoE0:multi-screen > mozilla-b2g:master Basically looks good to me except a few comments only. Please take a look on GitHub. Thanks.
Attachment #8701975 - Flags: feedback?(lchang) → feedback+
Depends on: 1208417
Comment on attachment 8701975 [details] [gaia] KuoE0:multi-screen > mozilla-b2g:master Hi Luke, can you review the PR again?
Attachment #8701975 - Flags: review?(lchang)
Comment on attachment 8701975 [details] [gaia] KuoE0:multi-screen > mozilla-b2g:master Hi Tommy, Since you're going to improve your patch a bit, I'd like to cancel my review request first. Please set it back when you finish. Thanks.
Attachment #8701975 - Flags: review?(lchang)
Hi Luke, I already update my patch. Can you review it again?
Attachment #8701975 - Flags: review?(lchang)
Comment on attachment 8701975 [details] [gaia] KuoE0:multi-screen > mozilla-b2g:master Looks good except one comment left on GitHub. Please help to address that. Thanks.
Attachment #8701975 - Flags: review?(lchang) → review+
Keywords: checkin-needed
landed on master: https://github.com/mozilla-b2g/gaia/commit/84ac7c8812016e03f794916170b1b82976930ac7
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: