Rewrote so that the sqlite.def -> sqlite.symbols diff is simpler to review.

I now see warnings such as " 1:08.00 ld: warning: cannot export hidden symbol __PR_Darwin_x86_64_AtomicIncrement from ../../../nsprpub/pr/src/md/unix/os_Darwin.o 1:08.00 ld: warning: cannot export hidden symbol __PR_Darwin_x86_64_AtomicDecrement from ../../../nsprpub/pr/src/md/unix/os_Darwin.o 1:08.00 ld: warning: cannot export hidden symbol __PR_Darwin_x86_64_AtomicSet from ../../../nsprpub/pr/src/md/unix/os_Darwin.o 1:08.00 ld: warning: cannot export hidden symbol __PR_Darwin_x86_64_AtomicAdd from ../../../nsprpub/pr/src/md/unix/os_Darwin.o "

(In reply to Jean-Yves Avenard [:jya] from comment #7) > I now see warnings such as " 1:08.00 ld: warning: cannot export hidden > symbol __PR_Darwin_x86_64_AtomicIncrement from > ../../../nsprpub/pr/src/md/unix/os_Darwin.o > 1:08.00 ld: warning: cannot export hidden symbol > __PR_Darwin_x86_64_AtomicDecrement from > ../../../nsprpub/pr/src/md/unix/os_Darwin.o > 1:08.00 ld: warning: cannot export hidden symbol > __PR_Darwin_x86_64_AtomicSet from ../../../nsprpub/pr/src/md/unix/os_Darwin.o > 1:08.00 ld: warning: cannot export hidden symbol > __PR_Darwin_x86_64_AtomicAdd from ../../../nsprpub/pr/src/md/unix/os_Darwin.o > " Not a problem.

(In reply to Mike Hommey [:glandium] (VAC: 31 Dec - 11 Jan) from comment #8) > (In reply to Jean-Yves Avenard [:jya] from comment #7) > > I now see warnings such as " 1:08.00 ld: warning: cannot export hidden > > symbol __PR_Darwin_x86_64_AtomicIncrement from > > ../../../nsprpub/pr/src/md/unix/os_Darwin.o > > 1:08.00 ld: warning: cannot export hidden symbol > > __PR_Darwin_x86_64_AtomicDecrement from > > ../../../nsprpub/pr/src/md/unix/os_Darwin.o > > 1:08.00 ld: warning: cannot export hidden symbol > > __PR_Darwin_x86_64_AtomicSet from ../../../nsprpub/pr/src/md/unix/os_Darwin.o > > 1:08.00 ld: warning: cannot export hidden symbol > > __PR_Darwin_x86_64_AtomicAdd from ../../../nsprpub/pr/src/md/unix/os_Darwin.o > > " > > Not a problem. All that actually says is that we can probably remove the "_PR_*" entry from the symbols file without any problem.

Didn't feel like filing a separate bug for this.

Comment on attachment 8702006 [details] [diff] [review] Part 1 - Add support for a more-or-less cross-platform symbols file Review of attachment 8702006 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/rules.mk @@ +461,5 @@ > EXTRA_DEPS += $(LD_VERSION_SCRIPT) > endif > endif > > +ifdef SYMBOLS_FILE I'm not the biggest fan of adding this to rules.mk - I'd prefer writing it to backend.mk from recursivemake.py. But I'll allow it.

Comment on attachment 8702004 [details] [diff] [review] Part 2 - Convert sqlite and nss to SYMBOLS_FILE Review of attachment 8702004 [details] [diff] [review]: ----------------------------------------------------------------- Yay for eliminating gnarly make foo.

Comment on attachment 8702460 [details] [diff] [review] Remove _PR_* symbols from nss.symbols Review of attachment 8702460 [details] [diff] [review]: ----------------------------------------------------------------- Not sure if I fully grok the implications of this since I'm not intimate with the C++ and 3rd party linking side of things. But not exporting "internal" symbols sounds reasonable to me. One concern I have is for plugin and 3rd party app compatibility. I reckon if there is fallout we can revert this easily. Flagging bsmedberg in case he has an opinion.

Note the only affected symbols are _PR_<architecture>_Atomic{Decrement,Set,Add,Increment}, they are not exposed in public headers, have a different name on each architecture, and have a public API: PR_Atomic{Decrement,Set,Add,Increment}.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b61f9f09b04 https://hg.mozilla.org/integration/mozilla-inbound/rev/186450f22aab https://hg.mozilla.org/integration/mozilla-inbound/rev/3b12a8b128ac https://hg.mozilla.org/integration/mozilla-inbound/rev/8ee36e6d8dc7 https://hg.mozilla.org/integration/mozilla-inbound/rev/5db0dc925186

https://hg.mozilla.org/mozilla-central/rev/3b61f9f09b04 https://hg.mozilla.org/mozilla-central/rev/186450f22aab https://hg.mozilla.org/mozilla-central/rev/3b12a8b128ac https://hg.mozilla.org/mozilla-central/rev/8ee36e6d8dc7 https://hg.mozilla.org/mozilla-central/rev/5db0dc925186

Comment on attachment 8702460 [details] [diff] [review] Remove _PR_* symbols from nss.symbols If this doesn't break our build, it should be fine.