Closed Bug 1235977 Opened 9 years ago Closed 9 years ago

[TV][2.5] Video can't be played in the preview mode

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(1 file)

Video can't be played in the preview mode from Marketplace but can be played when you add it to Apps.
Comment on attachment 8703070 [details] [gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master Hi Rex, Could you please review this patch? Thanks. The root cause is related to Audio Channel Policy. When we was trying to migrate that feature from phone to TV, we found that HierarchyManager was missing from TV system so we had to workaround it by using FocusManager instead. Since they're not identical, it needs us to specify which "class" should be handled by Audio Channel Policy modules in our workaround and we specified "AppWindow" only at that time. In this patch, I added "PreviewWindow" and "PopupWindow" to the white list so AudioChannelService can handle them well now.
Attachment #8703070 - Flags: review?(rexboy)
Comment on attachment 8703070 [details] [gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master Looks good to me. thanks.
Attachment #8703070 - Flags: review?(rexboy) → review+
blocking-b2g: 2.5? → 2.5+
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
Comment on attachment 8703070 [details] [gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): feature: TV OWD [User impact] if declined: all video can't be played. [Testing completed]: yes. [Risk to taking this patch] (and alternatives if risky): low. [String changes made]: N/A
Attachment #8703070 - Flags: approval-gaia-v2.5?
Comment on attachment 8703070 [details] [gaia] luke-chang:1235977_tv_preview_window_audio_policy > mozilla-b2g:master Approve for TV 2.5
Attachment #8703070 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Verify this issue on the latest build. Video can be played from Marketplace directly without adding it to Apps. [Build Info] simulator 2.6.20160222133739 gaia: https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a gecko: https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: