Closed
Bug 1236042
Opened 9 years ago
Closed 9 years ago
Create hotfix addon to update media.youtube-ua.override to false in Firefox 43.0.3
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox43 | + | affected |
| firefox44 | --- | unaffected |
| firefox45 | --- | unaffected |
| firefox46 | --- | unaffected |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jorgev
:
review+
|
Details | Diff | Splinter Review |
When Youtube will have fixed their bug, we will disable the workaround.
status-firefox43:
--- → affected
tracking-firefox43:
--- → +
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8703149 -
Flags: review?(jorge)
Attachment #8703149 -
Flags: review?(felipc)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sledru
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8703149 [details] [diff] [review]
youtube-workaround-hotfix.diff
Review of attachment 8703149 [details] [diff] [review]:
-----------------------------------------------------------------
Looks okay. There's just a discrepancy in which versions this applies to. As it stands, it will only apply to 43.0.3 - 43.*. If that's what we want, r+
::: v20151231.01/install.rdf
@@ +21,1 @@
> <em:maxVersion>43.*</em:maxVersion>
Shouldn't the maxVersion be 44.* to match what's in bootstrap.js?
Attachment #8703149 -
Flags: review?(jorge) → review+
|
||
Comment 3•9 years ago
|
||
YouTube says they plan to re-enable VP9 next week. They don't know exactly when.
status-firefox44:
--- → unaffected
status-firefox45:
--- → unaffected
status-firefox46:
--- → unaffected
|
|
Assignee | |
Comment 4•9 years ago
|
||
Actually, I only want the version 43.0.3 to be updated.
Is this declaration correct?
if (Services.vc.compare(Services.appinfo.version, "43.0.3") == 0) {
Attachment #8703149 -
Attachment is obsolete: true
Attachment #8703149 -
Flags: review?(felipc)
Attachment #8703291 -
Flags: review?(jorge)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8703291 [details] [diff] [review]
foo.dif
Review of attachment 8703291 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. 43.0.3 isn't in the allowed AMO versions, but I added it for this.
Attachment #8703291 -
Flags: review?(jorge) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/firefox-hotfixes/rev/3d48779b0399
Actually, we need to update also 43.0.3 & 43.0.4.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•