This is still missing coverage for: * The |getSubTree| and |move| API methods. * The |getChildren| and |getTree| methods where the promise is rejected. * The |create| method with an |index| property. * The |update| method with a |url| property, or a rejected promise. https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-bookmarks.js.html

I'll work on this next.

Note to self: getSubTree coverage landed in https://hg.mozilla.org/mozilla-central/rev/23566cc859df

move() coverage is covered in bug 1253652

Add coverage for getChildren() when the promise is rejected Add coverage for create() specifying index Add coverage for update() specifying a URL Add coverage for update() when the promise is rejected Review commit: https://reviewboard.mozilla.org/r/38681/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38681/

I believe that the attached patch, plus bug 1253652 should complete the coverage for bookmarks.

Comment on attachment 8727917 [details] MozReview Request: Bug 1236121 - Complete test coverage for the WebExtension bookmarks API, r?kmag https://reviewboard.mozilla.org/r/38681/#review35417 ::: toolkit/components/extensions/test/mochitest/test_ext_bookmarks.html:167 (Diff revision 1) > + parentId: results[0].parentId, I don't understand why you're using `results[0].parentId` for this. ::: toolkit/components/extensions/test/mochitest/test_ext_bookmarks.html:170 (Diff revision 1) > + }).then(results => { `results` doesn't seem like an appropriate name for this argument. ::: toolkit/components/extensions/test/mochitest/test_ext_bookmarks.html:288 (Diff revision 1) > - browser.test.assertEq(3, results.length, "Expected number of multiple results returned"); > + dump(JSON.stringify(results, null, 4)); Please remove. ::: toolkit/components/extensions/test/mochitest/test_ext_bookmarks.html:394 (Diff revision 1) > + }).then(expectedError, error => { This handler needs to be attached directly to `getChildren` so it doesn't catch errors from the rest of the chain.

Comment on attachment 8727917 [details] MozReview Request: Bug 1236121 - Complete test coverage for the WebExtension bookmarks API, r?kmag Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38681/diff/1-2/

https://reviewboard.mozilla.org/r/38681/#review35417 > I don't understand why you're using `results[0].parentId` for this. I think that was leftover from when I structured it differently. You're right, I don't need to do that anymore.