Closed
Bug 1236452
Opened 9 years ago
Closed 9 years ago
DOMHelpers.onceDOMReady
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
DOMHelpers.onceDOMReady never resolves if the target document is already loaded.
Ideally, the caller wouldn't have to check that before calling onceDOMReady,
but we need additional parameter (target URL) to check that.
I hit that issue while working on bug 1233463.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8704621 -
Attachment is obsolete: true
Comment on attachment 8706930 [details] [diff] [review]
patch v2
Review of attachment 8706930 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense!
Attachment #8706930 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/547e3501ff9ded7fe731f0481b7b93821ce93e5c
Bug 1236452 - Fix DOMHelpers.onceDOMReady against already loaded documents. r=jryans
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 8•9 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•