Skip trying to download things if the file system is not writable (temporary file or destination file).

Review commit: https://reviewboard.mozilla.org/r/29407/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29407/

Comment on attachment 8703594 [details] MozReview Request: Bug 1236507 - DownloadContentService: Skip download if file system is not writable. r?rnewman https://reviewboard.mozilla.org/r/29407/#review26321 ::: mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java:90 (Diff revision 1) > + if (!canWrite(temporaryFile, destinationFile)) { If the destination file isn't writeable, should this be recoverable?

(In reply to Richard Newman [:rnewman] from comment #2) > If the destination file isn't writeable, should this be recoverable? With failure counters: Yeah, if it's repeatable then we will stop trying. I can't really come up with a "normal user" reason why the destination file (which is inside the app directory for now) is not writable. This should be almost never be the case.

https://hg.mozilla.org/integration/fx-team/rev/61b71f449adc8a325cbc22dbf325f160d7975e52 Bug 1236507 - DownloadContentService: Skip download if file system is not writable. r=rnewman

(In reply to Sebastian Kaspari (:sebastian) from comment #3) > I can't really come up with a "normal user" reason why the destination file > (which is inside the app directory for now) is not writable. This should be > almost never be the case. And ... booom, I'm seeing this on a Genymotion emulator now. I filed bug 1236907 to investigate.