Closed
Bug 123666
Opened 23 years ago
Closed 23 years ago
Touch-up for disabled Classic buttons
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: gregvalure, Assigned: andreww)
Details
(Keywords: icon)
Attachments
(3 files)
Minor improvements to the disabled Forward and Stop buttons in Classic. The
bottom row of the disabled Forward button isn't hatched, and the hatching in the
disabled Stop button breaks pattern, causing banding.
The replacement images were made from the originals so they are the same size
and color depth, have the same palette, and the icons are positioned correctly
within them. Only the absolute minimum required was changed.
2002-02-04-06 Win98 (0.9.8 milestone)
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
Reporter | ||
Comment 3•23 years ago
|
||
Comment 4•23 years ago
|
||
confirming for consideration
Comment on attachment 67997 [details]
Fixed chrome://navigator/skin/icons/btn1.gif
r=andreww just make sure that your changes dont change the pixel offsets of
the images so that the -moz-image-regions dont get off track
Attachment #67997 -
Flags: review+
Comment on attachment 67998 [details]
Fixed chrome://communicator/skin/icons/btn1.gif
r=andreww
Attachment #67998 -
Flags: review+
Reporter | ||
Comment 7•23 years ago
|
||
I worked from the originals and was careful about not changing anything else.
They're okay in that respect.
Reporter | ||
Comment 10•23 years ago
|
||
Your review should still be valid considering you didn't create the replacement
images.
Assignee | ||
Comment 11•23 years ago
|
||
hewitt - can you sr?
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Comment 12•23 years ago
|
||
sr=hewitt
Assignee | ||
Comment 13•23 years ago
|
||
ok greg are the gif's you posted here the ones you want me to check in, or
do you want to attach a zip file with the gifs together?
Reporter | ||
Comment 14•23 years ago
|
||
The two gifs attached can go in as is.
Reporter | ||
Comment 15•23 years ago
|
||
Just curious, but why Mozilla 1.0? Why can't this go in now?
Comment 16•23 years ago
|
||
FYI: see also bug 125526 which wants to fix the weird gray stuff in the
navigation toolbar icons.
Assignee | ||
Comment 17•23 years ago
|
||
Ill try to check this in today.
Assignee | ||
Comment 18•23 years ago
|
||
Im guessing 125526 superceeds this one since it incorporates this
image's changes. Will get that one checked in.
Comment 19•23 years ago
|
||
andreww, please do check in the second gif from this bug
(chrome://communicator/skin/icons/btn1.gif). It is not covered in bug 125526, I
only stole (and tried to improve) the first gif from this bug.
Assignee | ||
Comment 20•23 years ago
|
||
yep - I understand. I'll check in the nav one from the other bug and the
communicator one from this bug.
Assignee | ||
Comment 21•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•