Closed Bug 123666 Opened 23 years ago Closed 23 years ago

Touch-up for disabled Classic buttons

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: gregvalure, Assigned: andreww)

Details

(Keywords: icon)

Attachments

(3 files)

Minor improvements to the disabled Forward and Stop buttons in Classic. The bottom row of the disabled Forward button isn't hatched, and the hatching in the disabled Stop button breaks pattern, causing banding. The replacement images were made from the originals so they are the same size and color depth, have the same palette, and the icons are positioned correctly within them. Only the absolute minimum required was changed. 2002-02-04-06 Win98 (0.9.8 milestone)
Attached image Shot of changes (deleted) —
confirming for consideration
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: icon
Comment on attachment 67997 [details] Fixed chrome://navigator/skin/icons/btn1.gif r=andreww just make sure that your changes dont change the pixel offsets of the images so that the -moz-image-regions dont get off track
Attachment #67997 - Flags: review+
Comment on attachment 67998 [details] Fixed chrome://communicator/skin/icons/btn1.gif r=andreww
Attachment #67998 - Flags: review+
I worked from the originals and was careful about not changing anything else. They're okay in that respect.
andrew, can you take this?
Assignee: hewitt → andreww
ok - though this may need a new reviewer now :)
Your review should still be valid considering you didn't create the replacement images.
hewitt - can you sr?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
sr=hewitt
ok greg are the gif's you posted here the ones you want me to check in, or do you want to attach a zip file with the gifs together?
The two gifs attached can go in as is.
Target Milestone: mozilla0.9.9 → mozilla1.0
Just curious, but why Mozilla 1.0? Why can't this go in now?
FYI: see also bug 125526 which wants to fix the weird gray stuff in the navigation toolbar icons.
Ill try to check this in today.
Im guessing 125526 superceeds this one since it incorporates this image's changes. Will get that one checked in.
andreww, please do check in the second gif from this bug (chrome://communicator/skin/icons/btn1.gif). It is not covered in bug 125526, I only stole (and tried to improve) the first gif from this bug.
yep - I understand. I'll check in the nav one from the other bug and the communicator one from this bug.
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified (2002-02-21-08-trunk)
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: