test getVertexAttrib PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_BUFFER_BINDING) is buffer PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_ENABLED) is true PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_SIZE) is 4 PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_STRIDE) is 0 PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_TYPE) is gl.FLOAT PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_NORMALIZED) is false PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_DIVISOR) is 0 FAIL gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_INTEGER) should be false (of type boolean). Was null (of type object). PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_DIVISOR) is 2 PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_STRIDE) is 36 PASS gl.getVertexAttribOffset(1, gl.VERTEX_ATTRIB_ARRAY_POINTER) is 12 PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_ENABLED) is false PASS gl.getVertexAttrib(1, gl.CURRENT_VERTEX_ATTRIB) is [5, 6, 7, 8] PASS gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_TYPE) is gl.INT FAIL gl.getVertexAttrib(1, gl.VERTEX_ATTRIB_ARRAY_INTEGER) should be true (of type boolean). Was null (of type object). FAIL getError expected: NO_ERROR. Was INVALID_ENUM : PASS getVertexAttrib correctly handled invalid parameter enums PASS getError was expected value: INVALID_VALUE : after evaluating: gl.getVertexAttrib(16, gl.CURRENT_VERTEX_ATTRIB)

Review commit: https://reviewboard.mozilla.org/r/31583/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31583/

Comment on attachment 8709851 [details] MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert https://reviewboard.mozilla.org/r/31583/#review28281 ::: dom/canvas/WebGLContextVertices.cpp:363 (Diff revision 1) > + } You need a break; at the end of this block.

Comment on attachment 8709851 [details] MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31583/diff/1-2/

Comment on attachment 8709851 [details] MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert https://reviewboard.mozilla.org/r/31583/#review28449 ::: dom/canvas/WebGLContextVertices.cpp:361 (Diff revision 2) > + if (IsWebGL2()) > + { > + return JS::BooleanValue(mBoundVertexArray->mAttribs[index].integer); if (IsWebGL2()) return JS::...; break;

Comment on attachment 8709851 [details] MozReview Request: Bug 1236786 - [WebGL2] pass getVertexAttrib in gl-object-get-calls.html, r?jgilbert Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31583/diff/2-3/