Joseph Yeh [:joseph] Assignee
	Comment 1 • 9 years ago

Hi Davor,

This patch includes two commits. The first commit will add the route '/tv' so the routing won't failed on the TV Marketplace server.

The second commit looks like a bug in marketplace-template, settings_local_hosted.js seems different from settings_local.js.dist which caused a javascript error `ReferenceError: settings is not defined` on the TV Marketplace server.

Thanks!

	Joseph Yeh [:joseph] Assignee
	Comment 2 • 9 years ago

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/25c0c49a998de84756d7f38f0a72dca0279790ee

	David Durst [:ddurst]
	Comment 3 • 9 years ago

If this has landed, I assume this is closed?

	Joseph Yeh [:joseph] Assignee
	Comment 4 • 9 years ago

I left this open because there are more issues needed to be solved :(

	Joseph Yeh [:joseph] Assignee
	Comment 6 • 9 years ago

Hi Allen,

I send a PR to zamboni repo with some updates for TV Marketplace settings (https://github.com/mozilla/zamboni/pull/3492), but it looks like the CI build has failed. Can you help me check if I made something wrong?

Thanks!

	Allen Short [:ashort]
	Comment 7 • 9 years ago

These tests intermittently fail and can be ignored. I don't see any problems introduced by your code.

	Joseph Yeh [:joseph] Assignee
	Comment 8 • 9 years ago

Thanks Allen. Looks good now.

	Joseph Yeh [:joseph] Assignee
	Comment 9 • 9 years ago

Update icon url to production server in manifest.