This unreachable code landed in bug 1020629 (to fix DrawTargetSkia::CopySurface for A8 surfaces). The code was disabled with `if (false)`. clang's -Wunreachable-code warnings were recently enabled in bug 1235717, but clang only reports this warning instance when I compile with --disable-optimize. The disabled code has a comment saying "This is a fast path that is disabled for now to minimize risk". Should we just enable the fast path? If not now, then when? The disabled code landed 1.5 years ago. :) gfx/2d/DrawTargetSkia.cpp:803:17: error: code will never be executed [-Werror,-Wunreachable-code] if (false && !bitmap.mBitmap.getTexture() && mCanvas->imageInfo() == bitmap.mBitmap.info()) { ^~~~~~

Comment on attachment 8704738 [details] [diff] [review] Wunreachable-code_DrawTargetSkia.patch Review of attachment 8704738 [details] [diff] [review]: ----------------------------------------------------------------- This is being fixed in bug 1239040

Awesome. Thanks! :)