Andrew McCreight [:mccr8] Reporter
	Description • 9 years ago

dom/base/test/test_mutationobservers.html is disabled with e10s because it uses showModalDialog, but it really only uses it for one subtest. That test could be moved into a separate test, or maybe test_mutationobservers.html could just be enabled for e10s. It seems to handle the case where showModalDialog by catching an exception.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 1 • 9 years ago

showModalDialog either must be implemented in e10s or hidden from window interface.
And then the test could just check if showModalDialog is available and if not, continue to the next subtest.
try-catch around showModalDialog might be indeed enough.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 2 • 9 years ago

Seems to work locally
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74e38aad93f5

	Andrew McCreight [:mccr8] Reporter
	Comment 3 • 9 years ago

Comment on attachment 8704884 [details] [diff] [review]
patch

Review of attachment 8704884 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/56170016142d

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/56170016142d