Closed Bug 1237541 Opened 9 years ago Closed 9 years ago

[TV][2.5] Preview window back key also trigger on parent app window

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(1 file)

[gaia] rickychien:fix-back-focus > mozilla-b2g:master
(deleted), text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details
document.activeElement cannot focus immediately when browsing slow loading web page (ex: expedia.com) which causes parent app window will also back to previous page.
Comment on attachment 8705166 [details] [gaia] rickychien:fix-back-focus > mozilla-b2g:master I noticed that we forgot to set parentWindow.frontWindow = previewWindow; after preview window being created and also fix bug for focusManager. Here is a small patch for addressing this issue.
Attachment #8705166 - Flags: review?(lchang)
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
blocking-b2g: 2.5? → 2.5+
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
Summary: [TV] Preview window back key also trigger on parent app window → [TV][2.5] Preview window back key also trigger on parent app window
Comment on attachment 8705166 [details] [gaia] rickychien:fix-back-focus > mozilla-b2g:master Good job! Thanks.
Attachment #8705166 - Flags: review?(lchang) → review+
Thank you Luke. Landed in master: https://github.com/mozilla-b2g/gaia/commit/514132d2e74218d607963ae1fe4a4e0ded392f22
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8705166 [details] [gaia] rickychien:fix-back-focus > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1225081 [User impact] if declined: Unexpected UI behaviors when back key is triggered. [Testing completed]: manual tested on local [Risk to taking this patch] (and alternatives if risky): n/a [String changes made]: n/a
Attachment #8705166 - Flags: approval-gaia-v2.5?
Comment on attachment 8705166 [details] [gaia] rickychien:fix-back-focus > mozilla-b2g:master Approve for TV 2.5
Attachment #8705166 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: