Closed
Bug 1238187
Opened 9 years ago
Closed 9 years ago
"Synced Tabs" entry on history panel is shown in a disabled state
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 46
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
There is a "Synced Tabs" item on the history panel. This has |disabled="true"| defined in the XUL and while the code correctly manages the hidden state of the item it never removes the disabled attribute. The end result is that the item is correctly hidden when Sync is not configured, but shown and disabled when it is.
Attachment #8705900 -
Flags: review?(gijskruitbosch+bugs)
Updated•9 years ago
|
Attachment #8705900 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8705900 [details] [diff] [review]
0001-Bug-XXXXXXX-Synced-Tabs-entry-on-history-panel-is-al.patch
Approval Request Comment
[Feature/regressing bug #]: Synced Tabs Panel UI
[User impact if declined]: "Synced Tabs" on the history panel will be disabled for Sync users.
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Trivial 1 line patch
[String/UUID change made/needed]: None
Attachment #8705900 -
Flags: approval-mozilla-aurora?
Comment 3•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•9 years ago
|
Assignee: nobody → markh
status-firefox45:
--- → affected
Updated•9 years ago
|
Attachment #8705900 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 4•9 years ago
|
||
bugherder uplift |
Updated•9 years ago
|
Flags: qe-verify+
Comment 5•9 years ago
|
||
I was able to reproduce this issue on Firefox 46.0a1 (2016-01-08) under Windows 10 64-bit.
Verified fixed on Firefox 46.0a1 (2016-01-13/14) and Firefox 45.0a2 (2016-01-14) using Windows 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•