Closed Bug 1238561 Opened 9 years ago Closed 6 years ago

Put an upper-limit to the statistics gathered by WebRTC

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox46 --- affected

People

(Reporter: Dexter, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

In order to prevent the uncontrolled growth of Telemetry pings, we should properly limit the ping entries, where needed. As of now, WebRTC Telemetry doesn't seem to have a huge impact on the ping size but there seems to be no control on how many entries the WebRTC section of the main ping will contain [0]. [0] - https://dxr.mozilla.org/mozilla-central/rev/6020a4cb41a77a09484c24a5875bb221714c0e6a/media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp#975
Whiteboard: [measurement:client]
Blocks: 1186986
:drno, does it make sense to put limits in place for IceCandidatesStats?
Flags: needinfo?(drno)
The idea behind the code you pointed at is that it aggregates all WebRTC based calls into integers in one hash table already. So basically if you make a thousand WebRTC calls between two Telemetry pings the code should only generate a single WebRTC JSON entry with a bunch of integers up to a thousand in it. https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/WebrtcTelemetry.cpp#16 Now the data which gets collected and aggregated gets serialized into JSON from here: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Telemetry.cpp#2574 I have no idea how often this gets called. But it is quite possible that some of my assumptions are/were wrong or that I'm simply not understanding the question/problem here properly.
Flags: needinfo?(drno)
This sounds like there are limits in place already.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.