Closed
Bug 1238732
Opened 9 years ago
Closed 9 years ago
Report yasm version in configure logs
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | affected |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
The configure script parses out the yasm version so we can do minimum-required checks. Report this version in the configure output so developers can tell what was available per bug 1224408.
Attachment #8706581 -
Flags: review?(mshal)
Comment 1•9 years ago
|
||
Comment on attachment 8706581 [details] [diff] [review]
0001-Bug-1224408-Print-yasm-version.-r-mshal.patch
>+ AC_MSG_RESULT([$YASM_VERSION (v$_YASM_MAJOR_VERSION.$_YASM_MINOR_VERSION.$_YASM_RELEASE)])
Do you need the "v" here for anything in particular? I'd think the strings should match up, like "yasm version... 1.2.0 (1.2.0)" instead of "yasm version... 1.2.0 (v1.2.0)". r+ either way though.
Attachment #8706581 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Hmm. I copied what I did for rust, in analogy with the prefix convention for git tags. I think it's helpful to have some way to distinguish the parsed version from the literal string, but maybe the leading 'v' only helps because I know that's what it means.
But it's not a git tag. Maybe "yasm version '1.2.0' (1.2.0)" would be more clear?
Assignee | ||
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
Up to you - I only saw one other example where the version is displayed next to the version we're looking for:
checking for minimum required perl version >= 5.006... 5.020002
Not a big deal either way :)
Assignee | ||
Comment 5•9 years ago
|
||
Ok, thanks. I'll leave it with bug 1239366 for now.
https://hg.mozilla.org/mozilla-central/rev/6f46422023dc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•