Closed
Bug 1239436
Opened 9 years ago
Closed 9 years ago
Remove in-place mutation of trees' expanded sets in reducers
Categories
(DevTools :: Memory, defect, P2)
DevTools
Memory
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: linclark)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
We might be able to just get away with replacing the Set with a flat array and doing the O(n) lookup time. The expanded sets are probably pretty small, all things considered.
We could also generate a fresh Set for each state reduction. Still O(n), but then we aren't doing an additional O(n) search for each lookup.
Finally, we could either implement or grab an existing persistent immutable set.
Reporter | ||
Updated•9 years ago
|
Has STR: --- → irrelevant
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → lclark
Assignee | ||
Comment 2•9 years ago
|
||
This patch replaces the mutable sets with Immutable.js sets. You'll need to apply the patch in 1253784 first.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f87d7721084e
Attachment #8731399 -
Flags: review?(nfitzgerald)
Assignee | ||
Updated•9 years ago
|
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8731399 [details] [diff] [review]
Bug1239436-immutable-set.patch --- Depends on 1253784
Review of attachment 8731399 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent!!!
Thank you, Lin!
Attachment #8731399 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•