Closed Bug 1239719 Opened 9 years ago Closed 9 years ago

Please vendor the python requests library in mozilla-central

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: dminor, Unassigned)

References

Details

Please package the python requests library in MozillaBuild. It will make reporting build system telemetry data much easier (see bug 1237610).
Assignee: nobody → ryanvm
I've been considering shipping mozregression with MozillaBuild, which would get this for free. One way or another, I'll include it in the next release.
I think we should vendor requests in mozilla-central instead. We already vendor it in version-control-tools. Also, mach commands can install Python packages in the virtualenv used by the build system. Search for "activate_virtualenv" and "install_pip_package" in mozilla-central.
In this case, I assume the chicken and egg situation (having it available prior to cloning m-c) doesn't apply since the work depending on it would also require a clone of m-c. Dan, do you agree with comment 2?
Flags: needinfo?(dminor)
That's fine by me, my use case is reporting data after mach commands execute, so a clone of m-c will be available by then :)
Flags: needinfo?(dminor)
Moving this over to Build Config then, thanks.
Assignee: ryanvm → nobody
No longer blocks: MozillaBuild2.2
Component: MozillaBuild → Build Config
Product: mozilla.org → Core
Summary: Please package the python requests library in MozillaBuild → Please vendor the python requests library in mozilla-central
Version: other → Trunk
Such a good idea, it seems we already did it [1] :) [1] https://dxr.mozilla.org/mozilla-central/source/python/requests
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.