Latest visual spec (updated by 1/13) in bug 1235128 fallback to old style system banner so I will revert the patch of bug 1235128 and uplift to v2.5 as well.

I'm also revert patch for smart-components.

[Blocking Requested - why for this release]:

Comment on attachment 8708194 [details] [gaia] mozilla-b2g:revert-33716-extendSystemBanner > mozilla-b2g:master Luke, I'd like to inform you the latest visual spec changed and decided to fallback old style system banner.

Josh, visual spec decided to fallback old style system banner so bug 1235128 will be backed out here and uplift to v2.5 branch.

(In reply to Ricky Chien [:rickychien] from comment #6) > Josh, visual spec decided to fallback old style system banner so bug 1235128 > will be backed out here and uplift to v2.5 branch. Thanks for the heads up. Please raise uplift request when you got r+.

Reverted in gaia master https://github.com/mozilla-b2g/gaia/commit/6dfb1a87132ca48463ed50797a33e6027493330d Reverted in smart-components https://github.com/smart-components/smart-banner/commit/eaa9e8fd7a3e39556ab54f4bea3d853c8458d7c9

Comment on attachment 8708194 [details] [gaia] mozilla-b2g:revert-33716-extendSystemBanner > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): revert bug 1235128 [User impact] if declined: fall back to old system banner UI [Testing completed]: verified manually on local [Risk to taking this patch] (and alternatives if risky): none [String changes made]: added-to-app deleted-from-apps preview-app

Comment on attachment 8708194 [details] [gaia] mozilla-b2g:revert-33716-extendSystemBanner > mozilla-b2g:master Approve for TV 2.5

has conflicts uplifting to 2.5 - could you take a look and maybe provide a 2.5 PR request ? Thanks!

Patch link generated by Github commit: https://github.com/rickychien/gaia/commit/34f4fc8183c0c289ee1db117711cada0d1256fb6.patch Hi, please take this patch, thanks!

Hi, this results on 2.5 in problems: adding 25.patch to series file applying 25.patch unable to find 'tv_apps/smart-system/bower_components/smart-banner/script.js' for patching 3 out of 3 hunks FAILED -- saving rejects to file tv_apps/smart-system/bower_components/smart-banner/script.js.rej unable to find 'tv_apps/smart-system/bower_components/smart-banner/style.css' for patching 3 out of 3 hunks FAILED -- saving rejects to file tv_apps/smart-system/bower_components/smart-banner/style.css.rej unable to find 'tv_apps/smart-system/index.html' for patching 4 out of 4 hunks FAILED -- saving rejects to file tv_apps/smart-system/index.html.rej unable to find 'tv_apps/smart-system/js/app_install_manager.js' for patching 3 out of 3 hunks FAILED -- saving rejects to file tv_apps/smart-system/js/app_install_manager.js.rej unable to find 'tv_apps/smart-system/js/browser_context_menu.js' for patching 8 out of 8 hunks FAILED -- saving rejects to file tv_apps/smart-system/js/browser_context_menu.js.rej unable to find 'tv_apps/smart-system/js/interactive_notifications.js' for patching 2 out of 2 hunks FAILED -- saving rejects to file tv_apps/smart-system/js/interactive_notifications.js.rej unable to find 'tv_apps/smart-system/js/preview_window.js' for patching 3 out of 3 hunks FAILED -- saving rejects to file tv_apps/smart-system/js/preview_window.js.rej unable to find 'tv_apps/smart-system/js/system_banner.js' for patching 2 out of 2 hunks FAILED -- saving rejects to file tv_apps/smart-system/js/system_banner.js.rej unable to find 'tv_apps/smart-system/locales/system.en-US.properties' for patching 2 out of 2 hunks FAILED -- saving rejects to file tv_apps/smart-system/locales/system.en-US.properties.rej unable to find 'tv_apps/smart-system/style/notifications/notifications.css' for patching 2 out of 2 hunks FAILED -- saving rejects to file tv_apps/smart-system/style/notifications/notifications.css.rej unable to find 'tv_apps/smart-system/style/system_banner/system_banner.css' for patching 1 out of 1 hunks FAILED -- saving rejects to file tv_apps/smart-system/style/system_banner/system_banner.css.rej could you take a look ? : )

Hi Tomcat, How do you apply the patch? Following steps works on my local: 1. checkout latest v2.5 branch (I can see latest commit is e36230a7b19ef5525543ae234408869b38ca65a9) 2. curl -L https://github.com/rickychien/gaia/commit/34f4fc8183c0c289ee1db117711cada0d1256fb6.patch | git am My console output: % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 26680 0 26680 0 0 10798 0 --:--:-- 0:00:02 --:--:-- 10801 Applying: Bug 1239914 - [TV][2.5] Fallback to old system banner

ah never did this that way :) applied and pushed that patch in https://github.com/mozilla-b2g/gaia/commit/53ba710af4baa6ea89f07f5d4bca36dc05476136

This issue is verified on v2.5 and v2.6 latest build. Shows old system banner with only one line string. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08 gecko: https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26 2.5 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3