Closed Bug 1240337 Opened 9 years ago Closed 7 years ago

Text editing in markup-view doesn't cancel when I select "unfocusable" nodes

Categories

(DevTools :: Inspector, defect, P2)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox46 affected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox46 --- affected

People

(Reporter: arni2033, Unassigned, Mentored)

References

(
URL
)

Details

(Whiteboard: [btpp-fix-later]) 

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160116030240
STR:
1. Open this "data:" url
>   data:text/html,<!DOCTYPE html>asdf<style>body::before{content:""}
2. Open devtools -> Inspector
3. Doubleclick "asdf" in markup-view to start editing the text
4.A) Click on "::before" in markup-view
4.B) Click on "<!DOCTYPE html>" in markup-view

Result:       After Step 4 textarea opened in Step 3 doesn't collapse
Expectations: Textarea should collapse after Step 4, because another node is selected
Thanks for filing! I wasn't aware of this one.
Triaging as P2 as this is a pretty important one to fix soon.

As discussed with Julian, he would be a great mentor for this if anyone wants to try and fix it. It shouldn't be a big deal. The 2 main files that I think are concerned by this bug are:

/devtools/client/inspector/markup/markup.js
/devtooos/client/shared/inplace-editor.js
Mentor: jdescottes
Priority: -- → P2
Whiteboard: [btpp-fix-later]
This may be fixed by bug 1255643 or vice-versa, because they look similar
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1255643
Hey, I cannot reproduce with a current build of mozilla-central or on the 51.0.1 release. Can you verify this seems to be fixed?

Tagging Julian, because arni2033 is not an active account.
Flags: needinfo?(jdescottes)
Can't reproduce either, closing!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jdescottes)
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.