Closed
Bug 1240420
Opened 9 years ago
Closed 9 years ago
Move checks of mismatched sample rate or channel numbers to AudioStream
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
https://hg.mozilla.org/mozilla-central/file/5644818538de2413cce52551e32b025e6c7e352e/dom/media/mediasink/DecodedAudioDataSink.cpp#l250
There are several benefits of doing this:
1. save the memory allocation in SilentChunk.
2. have a better chance for AudioStream::Downmix() to succeed when channel number is smaller than 8.
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → jwwang
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31745/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31745/
Attachment #8710409 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31747/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31747/
Attachment #8710410 -
Flags: review?(kinetik)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8710409 [details]
MozReview Request: Bug 1240420. Part 1 - move checks of mismatched sample rate or channel numbers to AudioStream. r=kinetik.
https://reviewboard.mozilla.org/r/31745/#review28549
Attachment #8710409 -
Flags: review?(kinetik) → review+
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8710410 [details]
MozReview Request: Bug 1240420. Part 2 - fix warnings of signed/unsigned comparison. r=kinetik.
https://reviewboard.mozilla.org/r/31747/#review28551
Attachment #8710410 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks for the review!
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52b05e612df9
https://hg.mozilla.org/mozilla-central/rev/632c8912c742
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•