Closed
Bug 1240607
Opened 9 years ago
Closed 9 years ago
Force CreateWindow interception to be a detour
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: bugzilla, Assigned: bugzilla)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
jimm
:
review+
Sylvestre
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
It looks like we have imperfect detection of Optimus DLL injection under bug 1218473. Until I find out why that is the case, I think we should force the CreateWindowExW interception to be a detour. This will definitively prevent further crashes even if the Optimus detection fails.
|
Assignee | |
Updated•9 years ago
|
Summary: Force CreateWindowExW interception to be a detour → Force CreateWindow interception to be a detour
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8709166 -
Flags: review?(jmathies)
|
||
Comment 3•9 years ago
|
||
[Tracking Requested - why for this release]:
this might be needed as addition to fix the nasty nvidia optimus crash in bug 1218473 for good, see https://bugzilla.mozilla.org/show_bug.cgi?id=1218473#c81. this is making up over 5% of crashes in rc1 atm, after it had already gone away in 44 beta 8 & 9.
status-firefox44:
--- → affected
status-firefox45:
--- → affected
tracking-firefox44:
--- → ?
tracking-firefox45:
--- → ?
|
||
Updated•9 years ago
|
Attachment #8709166 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8709166 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: bug 1213567 + NVidia Optimus Drivers
[User impact if declined]: Crashes
[Describe test coverage new/current, TreeHerder]: Existing tests will cover this
[Risks and why]: Low. well understood problem, simple solution
[String/UUID change made/needed]: None.
Attachment #8709166 -
Flags: approval-mozilla-beta?
Attachment #8709166 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Comment on attachment 8709166 [details] [diff] [review]
Patch
Aaron believes this is a safe fix, we've already made this change in other places, so should be a very low risk uplift. Taking it in Fx44 RC2.
Attachment #8709166 -
Flags: approval-mozilla-beta? → approval-mozilla-release+
|
||
Comment 6•9 years ago
|
||
| bugherder uplift | ||
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8709166 [details] [diff] [review]
Patch
Fix a crash, taking it.
Attachment #8709166 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 11•9 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•