One big problem with the current reading list is that not all articles are necessarily available offline, so it's inconsistent. We should stop letting users add things to the reading list that are reader-view-able. To do this, we need to stop letting them save arbitrary URLs to their reading list.

Agree, let's remove it from the share overlay. FYI, we are almost about to add "Open in Firefox" in this same menu too (in bug 1155860). But I don't think that should affect this work.

Attaching visual of what the share overlay would look like, once bug 1155860 is done. But, we aren't going to block on that bug (bug 1155860). This is just to show what we're talking about.

String resources are shared with the main app menu, and will therefore be remove in Bug 1234319 which aims to remove those items. Review commit: https://reviewboard.mozilla.org/r/38593/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38593/

Comment on attachment 8727664 [details] MozReview Request: Bug 1240728 - Remove add to reading list from the share overlay r?mcomella Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38593/diff/1-2/

Review commit: https://reviewboard.mozilla.org/r/38711/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38711/

Comment on attachment 8727664 [details] MozReview Request: Bug 1240728 - Remove add to reading list from the share overlay r?mcomella https://reviewboard.mozilla.org/r/38593/#review38617

Comment on attachment 8727971 [details] MozReview Request: Bug 1240728 - Post: cleanup / remove AddToReadingList from OverlayActionService r?mcomella https://reviewboard.mozilla.org/r/38711/#review38623 ::: mobile/android/base/java/org/mozilla/gecko/overlays/service/OverlayActionService.java (Diff revision 1) > @Override > public void run() { > shareTypes.clear(); > > shareTypes.put(ShareMethod.Type.ADD_BOOKMARK, new AddBookmark(context)); > - shareTypes.put(ShareMethod.Type.ADD_TO_READING_LIST, new AddToReadingList(context)); `ShareMethod.Type.ADD_TO_READING_LIST` is unused -- let's remove it.

https://hg.mozilla.org/integration/fx-team/rev/3c4f41b6babdb8a5339635495c228c0ad9fd53a0 Bug 1240728 - Remove add to reading list from the share overlay r=mcomella https://hg.mozilla.org/integration/fx-team/rev/eeea0cd4c9f24f4e43ad18584e528f7bff1d1cc4 Bug 1240728 - Post: cleanup / remove AddToReadingList from OverlayActionService r=mcomella

https://hg.mozilla.org/mozilla-central/rev/3c4f41b6babd https://hg.mozilla.org/mozilla-central/rev/eeea0cd4c9f2

Verified as fixed using: Device: Nexus 6 (Android 6.0) and Nexus 7 (Android 5.1) Build: Firefox for Android 48.0a1 (2016-04-10)